aparchoudhary commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1136516000
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/security/RouterDelegationTokenSecretManager.java:
##########
@@ -91,283 +117,173 @@ private boolean shouldIgnoreException(Exception e) {
* @param newKey DelegationKey
*/
@Override
- public void storeNewMasterKey(DelegationKey newKey) {
+ protected void storeNewMasterKey(DelegationKey newKey) throws IOException {
try {
federationFacade.storeNewMasterKey(newKey);
Review Comment:
Is the federationFacade being initialized with actual conf (that points to
Sql state store let's say). Because FederationStateStoreFacade.getInstance();
will always get an instance that is initialized with default conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
