virajjasani commented on PR #5407:
URL: https://github.com/apache/hadoop/pull/5407#issuecomment-1434946565
We have both options: test regex can be fixed as this is lock held info and
it is not considered stable as per compatibility guidelines.
Or if we don't want to include hostname, this change can be made too:
```
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
index aef62faf793..4b0e0203fa7 100644
---
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
@@ -8730,8 +8730,12 @@ private Supplier<String>
getLockReportInfoSupplier(String src, String dst,
StringBuilder sb = new StringBuilder();
String s = escapeJava(src);
String d = escapeJava(dst);
+ String ipAddr = addr != null ? "/" + addr.getHostAddress() : "null";
sb.append("ugi=").append(userName).append(",")
- .append("ip=").append(addr).append(",")
+ .append("ip=").append(ipAddr).append(",")
.append("src=").append(s).append(",")
.append("dst=").append(d).append(",");
if (null == status) {
```
@tasanuma I think we can fix test expression as this change (HDFS-15217) is
only present in trunk and not on branch-3.3, hence it is not released yet. Let
me fix test regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
