tasanuma commented on code in PR #5407:
URL: https://github.com/apache/hadoop/pull/5407#discussion_r1109228327
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -8787,7 +8787,10 @@ public void logAuditEvent(boolean succeeded, String
userName,
sb.setLength(0);
sb.append("allowed=").append(succeeded).append("\t")
.append("ugi=").append(userName).append("\t")
- .append("ip=").append(addr).append("\t")
+ // InetAddress#tostring can also return hostname in addition to IP
address.
+ // To not include hostname regardless of the hostname resolution,
we should
+ // only include IP address here. See HADOOP-18628.
Review Comment:
I think this change is independent of HADOOP-18628. So we don't need to
refer to it.
```suggestion
// only include IP address here.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
