[
https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682235#comment-17682235
]
ASF GitHub Bot commented on HADOOP-18206:
-----------------------------------------
virajjasani commented on code in PR #5315:
URL: https://github.com/apache/hadoop/pull/5315#discussion_r1091002213
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -949,13 +947,13 @@ protected void startMetricsLogger(Configuration conf) {
return;
}
- MetricsLoggerTask.makeMetricsLoggerAsync(MetricsLog);
+ MetricsLoggerTask.makeMetricsLoggerAsync(METRICS_LOG);
Review Comment:
makes sense
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -949,13 +947,13 @@ protected void startMetricsLogger(Configuration conf) {
return;
}
- MetricsLoggerTask.makeMetricsLoggerAsync(MetricsLog);
+ MetricsLoggerTask.makeMetricsLoggerAsync(METRICS_LOG);
// Schedule the periodic logging.
metricsLoggerTimer = new ScheduledThreadPoolExecutor(1);
metricsLoggerTimer.setExecuteExistingDelayedTasksAfterShutdownPolicy(
false);
- metricsLoggerTimer.scheduleWithFixedDelay(new MetricsLoggerTask(MetricsLog,
+ metricsLoggerTimer.scheduleWithFixedDelay(new
MetricsLoggerTask(METRICS_LOG,
Review Comment:
sounds good.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -360,7 +358,8 @@ public class DataNode extends ReconfigurableBase
FS_GETSPACEUSED_JITTER_KEY,
FS_GETSPACEUSED_CLASSNAME));
- public static final Log METRICS_LOG =
LogFactory.getLog("DataNodeMetricsLog");
+ public static final org.apache.log4j.Logger METRICS_LOG =
+ org.apache.log4j.Logger.getLogger("DataNodeMetricsLog");
Review Comment:
Yes that sounds good. Let me do that.
> Cleanup the commons-logging references in the code base
> -------------------------------------------------------
>
> Key: HADOOP-18206
> URL: https://issues.apache.org/jira/browse/HADOOP-18206
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Should always use slf4j
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
