[
https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682191#comment-17682191
]
ASF GitHub Bot commented on HADOOP-18206:
-----------------------------------------
virajjasani commented on PR #5315:
URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1409002069
Moreover, the main goal of this sub-task is to remove only commons-logging
references hence I think it would be better to replace Datanode/Namenode async
logger with SLF4J only (with log4j.properties including async logger).
> If those log4j refs can be hidden entirely within MetricsLoggerTask then
some reflection games could be done there perhaps. We would have to pass in the
name of the logger and let that class do any reflection-based look up of the
actual log.
We have sub-task to introduce hadoop-logging module altogether. The plan is
to move all log4j appender and other logic to that module and have reflection
do the work. All hadoop modules to only extend hadoop-logging module.
But this sub-task is only related to removal of commons-logging. And places
in hdfs would not be functional even as of today (without this patch) if client
doesn't include Log4J in the classpath (because dynamically adding appender is
part of hdfs own logic).
> Cleanup the commons-logging references in the code base
> -------------------------------------------------------
>
> Key: HADOOP-18206
> URL: https://issues.apache.org/jira/browse/HADOOP-18206
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Should always use slf4j
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
