slfan1989 commented on code in PR #4274:
URL: https://github.com/apache/hadoop/pull/4274#discussion_r871921651
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -392,5 +397,33 @@ public void getClusterMetrics(long duration){
duration);
metrics.succeededGetClusterMetricsRetrieved(duration);
}
+
+ public void getClusterNodes(long duration) {
+ LOG.info("Mocked: successful getClusterNodes call with duration {}",
duration);
+ metrics.succeededGetClusterNodesRetrieved(duration);
+ }
+ }
+
+ @Test
+ public void testSucceededGetClusterNodes() {
+ long totalGoodBefore = metrics.getNumSucceededGetClusterNodesRetrieved();
+ goodSubCluster.getClusterNodes(150);
+ Assert.assertEquals(totalGoodBefore + 1,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(150,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
+ 0);
+ goodSubCluster.getClusterNodes(300);
+ Assert.assertEquals(totalGoodBefore + 2,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(225,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
+ 0);
+ }
+
+ @Test
+ public void testGetClusterNodesFailed() {
+ long totalBadBefore = metrics.getClusterNodesFailedRetrieved();
+ badSubCluster.getClusterNodes();
+ Assert.assertEquals(totalBadBefore + 1,
Review Comment:
Thanks, I will fix the code here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
