goiri commented on code in PR #4274:
URL: https://github.com/apache/hadoop/pull/4274#discussion_r871649223
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##########
@@ -641,4 +643,17 @@ public void testGetApplicationsApplicationStateNotExists()
throws Exception{
Assert.assertNotNull(responseGet);
Assert.assertTrue(responseGet.getApplicationList().isEmpty());
}
+
+ @Test
+ public void testGetClusterNodesRequest() throws Exception {
+ LOG.info("Test FederationClientInterceptor : Get Cluster Nodeds request");
+ // null request
+ LambdaTestUtils.intercept(YarnException.class, "Missing getClusterNodes
request.",
+ () -> interceptor.getClusterNodes(null));
+ // normal request.
+ GetClusterNodesResponse response =
+ interceptor.getClusterNodes(GetClusterNodesRequest.newInstance());
+ Assert.assertEquals(subClusters.size(),
+ response.getNodeReports().size());
Review Comment:
1 line
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -392,5 +397,33 @@ public void getClusterMetrics(long duration){
duration);
metrics.succeededGetClusterMetricsRetrieved(duration);
}
+
+ public void getClusterNodes(long duration) {
+ LOG.info("Mocked: successful getClusterNodes call with duration {}",
duration);
+ metrics.succeededGetClusterNodesRetrieved(duration);
+ }
+ }
+
+ @Test
+ public void testSucceededGetClusterNodes() {
+ long totalGoodBefore = metrics.getNumSucceededGetClusterNodesRetrieved();
+ goodSubCluster.getClusterNodes(150);
+ Assert.assertEquals(totalGoodBefore + 1,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(150,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
Review Comment:
Put it in 1 line (if it fits within the line limit)
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -392,5 +397,33 @@ public void getClusterMetrics(long duration){
duration);
metrics.succeededGetClusterMetricsRetrieved(duration);
}
+
+ public void getClusterNodes(long duration) {
+ LOG.info("Mocked: successful getClusterNodes call with duration {}",
duration);
+ metrics.succeededGetClusterNodesRetrieved(duration);
+ }
+ }
+
+ @Test
+ public void testSucceededGetClusterNodes() {
+ long totalGoodBefore = metrics.getNumSucceededGetClusterNodesRetrieved();
+ goodSubCluster.getClusterNodes(150);
+ Assert.assertEquals(totalGoodBefore + 1,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(150,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
+ 0);
+ goodSubCluster.getClusterNodes(300);
+ Assert.assertEquals(totalGoodBefore + 2,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(225,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
+ 0);
+ }
+
+ @Test
+ public void testGetClusterNodesFailed() {
+ long totalBadBefore = metrics.getClusterNodesFailedRetrieved();
+ badSubCluster.getClusterNodes();
+ Assert.assertEquals(totalBadBefore + 1,
Review Comment:
Same line.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -392,5 +397,33 @@ public void getClusterMetrics(long duration){
duration);
metrics.succeededGetClusterMetricsRetrieved(duration);
}
+
+ public void getClusterNodes(long duration) {
+ LOG.info("Mocked: successful getClusterNodes call with duration {}",
duration);
+ metrics.succeededGetClusterNodesRetrieved(duration);
+ }
+ }
+
+ @Test
+ public void testSucceededGetClusterNodes() {
+ long totalGoodBefore = metrics.getNumSucceededGetClusterNodesRetrieved();
+ goodSubCluster.getClusterNodes(150);
+ Assert.assertEquals(totalGoodBefore + 1,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(150,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
Review Comment:
I see, is the delta. Make it a constant like ASSERT_DOUBLE_DELTA and make it
0.01 say.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -346,6 +346,11 @@ public void getClusterMetrics() {
LOG.info("Mocked: failed getClusterMetrics call");
metrics.incrGetClusterMetricsFailedRetrieved();
}
+
+ public void getClusterNodes() {
+ LOG.info("Mocked: failed getClusterNodes call");
Review Comment:
What is this for? I would avoid it.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -392,5 +397,33 @@ public void getClusterMetrics(long duration){
duration);
metrics.succeededGetClusterMetricsRetrieved(duration);
}
+
+ public void getClusterNodes(long duration) {
+ LOG.info("Mocked: successful getClusterNodes call with duration {}",
duration);
+ metrics.succeededGetClusterNodesRetrieved(duration);
+ }
+ }
+
+ @Test
+ public void testSucceededGetClusterNodes() {
+ long totalGoodBefore = metrics.getNumSucceededGetClusterNodesRetrieved();
+ goodSubCluster.getClusterNodes(150);
+ Assert.assertEquals(totalGoodBefore + 1,
+ metrics.getNumSucceededGetClusterNodesRetrieved());
+ Assert.assertEquals(150,
metrics.getLatencySucceededGetClusterNodesRetrieved(),
Review Comment:
What is the last 0 for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
