goiri commented on a change in pull request #3303:
URL: https://github.com/apache/hadoop/pull/3303#discussion_r689769484
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/configuration_test.h
##########
@@ -114,105 +111,6 @@ void writeDamagedConfig(const std::string& filename,
Args... args) {
out.open(filename);
out << stream.rdbuf();
}
-
-// TempDir: is deleted on destruction
-class TempFile {
Review comment:
Those are valuable but let's make this a refactor PR to make it more
explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
