GauthamBanasandra commented on a change in pull request #3303:
URL: https://github.com/apache/hadoop/pull/3303#discussion_r689750146
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/configuration_test.h
##########
@@ -114,105 +111,6 @@ void writeDamagedConfig(const std::string& filename,
Args... args) {
out.open(filename);
out << stream.rdbuf();
}
-
-// TempDir: is deleted on destruction
-class TempFile {
Review comment:
As I've mentioned in the corresponding JIRA -
https://issues.apache.org/jira/browse/HDFS-16174, header files should contain
only the declaration of the class and method signatures. The implementation
must be done in the cc files. Otherwise, these classes get recompiled everytime
they're **#include**d, leading to longer compilation times. Also, it's not a
good C++ practice to combine declaration and implementation in the header file,
unless it's a template class or method.
Another thing that I've done in this PR is to make this into a _test utility
library_, so that it's more modular and can be imported anywhere in libhdfs++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
