bharatviswa504 commented on a change in pull request #1511: HDDS-2162. Make
Kerberos related configuration support HA style config.
URL: https://github.com/apache/hadoop/pull/1511#discussion_r328897127
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerConfiguration.java
##########
@@ -119,10 +119,13 @@ public void testDefaultPortIfNotSpecified() throws
Exception {
String omNode1Id = "omNode1";
String omNode2Id = "omNode2";
String omNodesKeyValue = omNode1Id + "," + omNode2Id;
- conf.set(OMConfigKeys.OZONE_OM_NODES_KEY, omNodesKeyValue);
+ String serviceID = "service1";
+ conf.set(OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY, serviceID);
+ conf.set(OMConfigKeys.OZONE_OM_NODES_KEY + "." + serviceID,
+ omNodesKeyValue);
- String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode1Id);
- String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode2Id);
+ String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode1Id);
+ String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode2Id);
Review comment:
Discussed offline, from my understanding this is being done as to share
config across all OM's. And this PR is not changing any config loading code of
OM HA, it just added Kerberos/DB config as described in Jira description.
Anu said we don't require it, and we shall continue the discussion later to
see how we can do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
