bharatviswa504 commented on a change in pull request #1511: HDDS-2162. Make
Kerberos related configuration support HA style config.
URL: https://github.com/apache/hadoop/pull/1511#discussion_r328861588
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerConfiguration.java
##########
@@ -119,10 +119,13 @@ public void testDefaultPortIfNotSpecified() throws
Exception {
String omNode1Id = "omNode1";
String omNode2Id = "omNode2";
String omNodesKeyValue = omNode1Id + "," + omNode2Id;
- conf.set(OMConfigKeys.OZONE_OM_NODES_KEY, omNodesKeyValue);
+ String serviceID = "service1";
+ conf.set(OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY, serviceID);
+ conf.set(OMConfigKeys.OZONE_OM_NODES_KEY + "." + serviceID,
+ omNodesKeyValue);
- String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode1Id);
- String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode2Id);
+ String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode1Id);
+ String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode2Id);
Review comment:
> I have an uber comment on this JIRA. Under Ozone, what we really need is 3
+ 3 six kerberos Identites.
>
> Why don't we just follow the standard Kerberos SPN names? Simple take one
config key from the user, either the SPN or file name path the service kerberos
identity.
>
> Once you have this, we don't have to do any second guessing or munching of
names with any other strings -- after all it is just a service on a host. Code
is simpler, and the best part, it is simple enough for any one to understand.
In other words, what evil are we trying to prevent here with all the service
name munching ?
Not got your last part what is proposed.
This is done for Kerberos settings and also for other configs like OM DB
DIrs Http/Https Address. Suppose the user wants to use different keytab file
location/principal name it will also help in this situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
