Hexiaoqiao commented on a change in pull request #1104: HDFS-14318:dn cannot be 
recognized and must be restarted to recognize the Repaired disk
URL: https://github.com/apache/hadoop/pull/1104#discussion_r303930373
 
 

 ##########
 File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
 ##########
 @@ -819,6 +825,14 @@ public IOException call() {
             } else {
               effectiveVolumes.add(volume.toString());
               LOG.info("Successfully added volume: {}", volume);
+              if (errorDisk != null && !errorDisk.isEmpty()) {
 
 Review comment:
   It may be not necessary to check if `errorDisk` is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to