Hexiaoqiao commented on a change in pull request #1104: HDFS-14318:dn cannot be
recognized and must be restarted to recognize the Repaired disk
URL: https://github.com/apache/hadoop/pull/1104#discussion_r303935620
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -2191,6 +2208,44 @@ public void shutdown() {
tracer.close();
}
+ public void startCheckDiskThread() {
Review comment:
Suggest to use `ScheduledExecutorService` to schedule this task at fixed
rate. since,
1. same target,
2. simpler,
`checkDiskMutex`, it seems to me that it it no need to concurrency control.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
