steveloughran commented on a change in pull request #1086: HADOOP-16341.
ShutDownHookManager: Regressed performance on Hook remo…
URL: https://github.com/apache/hadoop/pull/1086#discussion_r303400069
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShutdownHookManager.java
##########
@@ -43,13 +43,10 @@
LoggerFactory.getLogger(TestShutdownHookManager.class.getName());
/**
- * remove all the shutdown hooks so that they never get invoked later
- * on in this test process.
+ * A new instance of ShutdownHookManager to ensure parallel tests
+ * don't have shared context
Review comment:
needs a "." at the end or javadoc is unhappy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
