steveloughran commented on a change in pull request #1086: HADOOP-16341.
ShutDownHookManager: Regressed performance on Hook remo…
URL: https://github.com/apache/hadoop/pull/1086#discussion_r303399741
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShutdownHookManager.java
##########
@@ -222,6 +217,20 @@ public void testDuplicateRegistration() throws Throwable {
}
+ @Test
+ public void testShutdownRemove() throws Throwable {
+ assertNotNull("No ShutdownHookManager", mgr);
+ assertEquals(0, mgr.getShutdownHooksInOrder().size());
+ Hook hook1 = new Hook("hook1", 0, false);
+ Hook hook2 = new Hook("hook2", 0, false);
+ mgr.addShutdownHook(hook1, 9); // create Hook1 with priority 9
+ assertTrue(mgr.hasShutdownHook(hook1)); // hook1 lookup works
+ assertEquals(1, mgr.getShutdownHooksInOrder().size()); // 1 hook
+ assertFalse(mgr.removeShutdownHook(hook2)); // can't delete hook2
Review comment:
again, all true/false asserts need a meaningful message. Enough to
understand what failed from the output of a test run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
