mukul1987 commented on a change in pull request #1051: HDDS-1748. Error message
for 3 way commit failure is not verbose. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1051#discussion_r300987073
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java
##########
@@ -259,7 +259,7 @@ public XceiverClientReply watchForCommit(long index, long
timeout)
replyFuture.get(timeout, TimeUnit.MILLISECONDS);
} catch (Exception e) {
Throwable t = HddsClientUtils.checkForException(e);
- LOG.warn("3 way commit failed ", e);
+ LOG.warn("3 way commit failed on pipeline " + pipeline, e);
Review comment:
This can be changed to parameterized logging as
LOG.warn("3 way commit failed on pipeline:{} ", pipeline, e);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
