mukul1987 commented on a change in pull request #1051: HDDS-1748. Error message
for 3 way commit failure is not verbose. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1051#discussion_r300987235
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java
##########
@@ -278,8 +278,9 @@ public XceiverClientReply watchForCommit(long index, long
timeout)
// replication.
commitInfoMap.remove(address);
LOG.info(
- "Could not commit " + index + " to all the nodes. Server " +
address
- + " has failed." + " Committed by majority.");
+ "Could not commit " + index + " on pipeline "
+ + pipeline + " to all the nodes. Server "
Review comment:
same here, lets change the logging to parametrized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
