bgaborg commented on a change in pull request #951: HADOOP-15183. S3Guard store
becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r293010385
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
##########
@@ -725,50 +975,55 @@ public void testDeleteTable() throws Exception {
intercept(IOException.class, "",
"Should have failed after the table is destroyed!",
() -> ddbms.listChildren(testPath));
- } finally {
ddbms.destroy();
- ddbms.close();
+ intercept(FileNotFoundException.class, "",
+ "Destroyed table should raise FileNotFoundException when pruned",
+ () -> ddbms.prune(0));
+ } finally {
+ destroy(ddbms);
}
}
+/*
Review comment:
Remove commented out test, or `@skip` with justification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
