bgaborg commented on a change in pull request #951: HADOOP-15183. S3Guard store
becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r293005305
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractRename.java
##########
@@ -64,12 +88,55 @@ public void testRenameDirIntoExistingDir() throws
Throwable {
Path destDir = path("dest");
Path destFilePath = new Path(destDir, "dest-512.txt");
- byte[] destDateset = dataset(512, 'A', 'Z');
- writeDataset(fs, destFilePath, destDateset, destDateset.length, 1024,
+ byte[] destDataset = dataset(512, 'A', 'Z');
+ writeDataset(fs, destFilePath, destDataset, destDataset.length, 1024,
false);
assertIsFile(destFilePath);
boolean rename = fs.rename(srcDir, destDir);
assertFalse("s3a doesn't support rename to non-empty directory", rename);
}
+
+ /**
+ * Test that after renaming, the nested file is moved along with all its
+ * ancestors. It is similar to {@link
#testRenamePopulatesDirectoryAncestors}.
+ *
+ * This is an extension testRenamePopulatesFileAncestors
+ * of the superclass version which does better
+ * logging of the state of the store before the assertions.
+ */
+ @Test
+ public void testRenamePopulatesFileAncestors2() throws Exception {
+ final S3AFileSystem fs = (S3AFileSystem)getFileSystem();
Review comment:
nit: space after cast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
