[
https://issues.apache.org/jira/browse/HADOOP-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603640#comment-16603640
]
Sean Mackrory commented on HADOOP-15635:
----------------------------------------
I think that check is good, but a few nits:
* I would call it dynamoUrlParameterProvided, as in theory it could be
pluggable, even though in practice it's always DynamoDB. Maybe
metadataStoreUriProvided?
* When would s3AFileSystem be null? You'd get an exception if there was a
problem.
* I'd just call it an S3 bucket, not an S3AFileSystem bucket.
{quote}Should we close this S3AFileSystem instance once we are done with the
check? {quote}
Probably good practice - although the JVM is going to shut down right away
anyway.
{quote} Is it possible to add an unit/integration test to verify the fix
?{quote}
There was one in the 001 patch, which went missing in the 002 patch.
> s3guard set-capacity command to fail fast if bucket is unguarded
> ----------------------------------------------------------------
>
> Key: HADOOP-15635
> URL: https://issues.apache.org/jira/browse/HADOOP-15635
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Minor
> Attachments: HADOOP-15635.001.patch, HADOOP-15635.002.patch
>
>
> If you try to do {{hadoop s3guard set-capacity s3a://landsat-pds}}, or any
> other bucket which exists but doesn't have s3guard enabled, you get a stack
> trace reporting that the ddb table doesn't exist.
> the command should check for the bucket being guarded and fail on that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
