[
https://issues.apache.org/jira/browse/HADOOP-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603612#comment-16603612
]
Hrishikesh Gadre commented on HADOOP-15635:
-------------------------------------------
[~gabor.bota] Thanks for posting the patch. I reviewed your latest patch
(HADOOP-15635-002.patch) and I have couple of comments,
* Should we pass the configuration object available to the S3GuardTool during
the construction of this file-system instance? While this code will work fine
when the config is available in the classpath, I am not sure if it will work as
expected when an external config directory is specified using --config param
for Hadoop CLI.
{noformat}
+ S3AFileSystem s3AFileSystem = new S3AFileSystem();{noformat}
* Should we close this S3AFileSystem instance once we are done with the check?
* Is it possible to add an unit/integration test to verify the fix ?
> s3guard set-capacity command to fail fast if bucket is unguarded
> ----------------------------------------------------------------
>
> Key: HADOOP-15635
> URL: https://issues.apache.org/jira/browse/HADOOP-15635
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Minor
> Attachments: HADOOP-15635.001.patch, HADOOP-15635.002.patch
>
>
> If you try to do {{hadoop s3guard set-capacity s3a://landsat-pds}}, or any
> other bucket which exists but doesn't have s3guard enabled, you get a stack
> trace reporting that the ddb table doesn't exist.
> the command should check for the bucket being guarded and fail on that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
