[
https://issues.apache.org/jira/browse/HADOOP-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554585#comment-16554585
]
Xiao Chen commented on HADOOP-15593:
------------------------------------
Thanks for revving [~gabor.bota] and [~eyang] for the prompt review. Patch
looks pretty good. I have 2 comments on the latest patch
- In case of either tgt is destroyed (either isDestroyed()==true or getEndTime
NPEs), is there any value in retrying? How about we do something like:
{code}
if (tgt.isDestroyed()) {
//log and return;
}
try{
tgtEndTime = tgt.getEndTime().getTime();
} catch (NullPointerException npe) {
// log and return;
}
{code}
{{runRenewalLoop}} var won't be necessary if we do this. Thoughts?
- The {{renewalFailures}} and {{renewalFailuresTotal}} metrics need to call
{{value()}} in order to be logged correctly.
This comes from existing code, but good to fix since we're touching it.
> UserGroupInformation TGT renewer throws NPE
> -------------------------------------------
>
> Key: HADOOP-15593
> URL: https://issues.apache.org/jira/browse/HADOOP-15593
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 3.0.0
> Reporter: Wei-Chiu Chuang
> Assignee: Gabor Bota
> Priority: Blocker
> Attachments: HADOOP-15593.001.patch, HADOOP-15593.002.patch,
> HADOOP-15593.003.patch, HADOOP-15593.004.patch
>
>
> Found the following NPE thrown in UGI tgt renewer. The NPE was thrown within
> an exception handler so the original exception was hidden, though it's likely
> caused by expired tgt.
> {noformat}
> 18/07/02 10:30:57 ERROR util.SparkUncaughtExceptionHandler: Uncaught
> exception in thread Thread[TGT Renewer for [email protected],5,main]
> java.lang.NullPointerException
> at
> javax.security.auth.kerberos.KerberosTicket.getEndTime(KerberosTicket.java:482)
> at
> org.apache.hadoop.security.UserGroupInformation$1.run(UserGroupInformation.java:894)
> at java.lang.Thread.run(Thread.java:748){noformat}
> Suspect it's related to [https://bugs.openjdk.java.net/browse/JDK-8154889].
> The relevant code was added in HADOOP-13590. File this jira to handle the
> exception better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
