[
https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513068#comment-16513068
]
Sean Mackrory commented on HADOOP-14918:
----------------------------------------
Thanks for working on this [~gabor.bota]. Overall I'm supportive of removing
the local option. It's caused a few problems, and I always use either the local
implementation or real Dynamo anyway.
I don't think we need fs.s3a.s3guard.ddb.test.table just for that one test
class. We already have been configuring fs.s3a.s3guard.ddb.table in the test's
config for other classes. That could just be used here too - let's not have a
separate config for it.
Haven't tested myself yet, but otherwise I think this looks about right. A few
nitpicks:
* Seems test.default.timeout could be more specifically named, at least until
we pass it in. e.g.
<test.default.timeout>${test.integration.timeout}</test.default.timeout>?
* Thanks for fixing the auth profile ID. Unrelated, but it's wrong - might as
well fix here.
* Change "Invocation getArgument at" to "InvocationOnMock.getArgumentAt" in the
JavaDoc
> Remove the Local Dynamo DB test option
> --------------------------------------
>
> Key: HADOOP-14918
> URL: https://issues.apache.org/jira/browse/HADOOP-14918
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0, 3.0.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-14918-001.patch, HADOOP-14918-002.patch,
> HADOOP-14918-003.patch, HADOOP-14918-004.patch, HADOOP-14918.005.patch
>
>
> I'm going to propose cutting out the localdynamo test option for s3guard
> * the local DDB JAR is unmaintained/lags the SDK We work with...eventually
> there'll be differences in API.
> * as the local dynamo DB is unshaded. it complicates classpath setup for the
> build. Remove it and there's no need to worry about versions of anything
> other than the shaded AWS
> * it complicates test runs. Now we need to test for both localdynamo *and*
> real dynamo
> * but we can't ignore real dynamo, because that's the one which matters
> While the local option promises to reduce test costs, really, it's just
> adding complexity. If you are testing with s3guard, you need to have a real
> table to test against., And with the exception of those people testing s3a
> against non-AWS, consistent endpoints, everyone should be testing with
> S3Guard.
> -Straightforward to remove.-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
