[
https://issues.apache.org/jira/browse/HADOOP-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492659#comment-16492659
]
Gabor Bota commented on HADOOP-14918:
-------------------------------------
I think a solution to this would be to create a test table on dynamo before
running any of these tests. That table could be created in beforeclass and
cleaned up in afterclass.
imho the only test which could cause a problem with this approach is
ITestDynamoDBMetadataStore#testInitialize where the table name should come from
the S3AFileSystem#getBucket, which is the bucket name, and obviously
destructive in a sense that [[email protected]] pointed out. For any other
test, the name of the table could be set in the auth-keys.xml, and if not
configured, the tests should fail in the setup phase.
[[email protected]] what do you mean by "merge all test cases into one"?
> remove the Local Dynamo DB test option
> --------------------------------------
>
> Key: HADOOP-14918
> URL: https://issues.apache.org/jira/browse/HADOOP-14918
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.9.0, 3.0.0
> Reporter: Steve Loughran
> Assignee: Gabor Bota
> Priority: Major
> Attachments: HADOOP-14918-001.patch, HADOOP-14918-002.patch,
> HADOOP-14918-003.patch, HADOOP-14918-004.patch
>
>
> I'm going to propose cutting out the localdynamo test option for s3guard
> * the local DDB JAR is unmaintained/lags the SDK We work with...eventually
> there'll be differences in API.
> * as the local dynamo DB is unshaded. it complicates classpath setup for the
> build. Remove it and there's no need to worry about versions of anything
> other than the shaded AWS
> * it complicates test runs. Now we need to test for both localdynamo *and*
> real dynamo
> * but we can't ignore real dynamo, because that's the one which matters
> While the local option promises to reduce test costs, really, it's just
> adding complexity. If you are testing with s3guard, you need to have a real
> table to test against., And with the exception of those people testing s3a
> against non-AWS, consistent endpoints, everyone should be testing with
> S3Guard.
> -Straightforward to remove.-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
