[
https://issues.apache.org/jira/browse/HADOOP-14488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049960#comment-16049960
]
Aaron Fabbri commented on HADOOP-14488:
---------------------------------------
Thanks for the excellent work here [~mackrorysd]. I applied the patch, added
some comments, removed a stray {{System.out.println()}} that was left in. I
also added a Precondition check to a helper function and renamed a variable or
two (child -> ancestor). Went through the code and it makes sense to me. Ran
{{ITestS3GuardListConsistency}} successfully in us-west-2. I'm cool with those
test cases staying there, since they do use the inconsistency injection.
Please review my updated patch and I will commit it if you are +1.
As an aside, I think we need to address the inconsistency tests being slow, due
to code like this:
{code}
+ Thread.sleep(2 * DEFAULT_DELAY_KEY_MSEC);
{code}
I have an idea for it (exposing a clear() or flush() function) and will address
in a separate JIRA.
> s3guard listStatus fails after renaming file into directory
> -----------------------------------------------------------
>
> Key: HADOOP-14488
> URL: https://issues.apache.org/jira/browse/HADOOP-14488
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Steve Loughran
> Assignee: Sean Mackrory
> Priority: Blocker
> Attachments: HADOOP-14488-HADOOP-13345-001.patch,
> HADOOP-14488-HADOOP-13345-002.patch, HADOOP-14488-HADOOP-13345-003.patch,
> HADOOP-14488-HADOOP-13345-004.patch, output.txt
>
>
> Running scala integration test with inconsistent s3 client & local DDB enabled
> {code}
> fs.rename("work/task-00/part-00", work)
> fs.listStatus(work)
> {code}
> The list status work fails with a message about the childStatus not being a
> child of the parent.
> Hypothesis: rename isn't updating the child path entry
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
