[
https://issues.apache.org/jira/browse/HADOOP-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932061#comment-15932061
]
John Zhuge commented on HADOOP-14038:
-------------------------------------
[[email protected]] Will include your comment in the next patch.
[~vishwajeet.dusane] Thanks for the review. Totally agree with you on that we
should be careful not to break any existing code.
It is a good idea to add what you suggested. It will cover one use case:
{{Configuration#set}} is called with an old key, then conf is read with the new
key.
There is another use case when a config file with old keys is loaded. These are
2 different code paths in Configuration class. I will add an unit test for it
as well.
For TestValidateConfiguration, I will keep it then since HADOOP-13037 reviewed
this class already even though IMHO the accidental modification is already
mitigated by 3 measures:
# The properties are in a class called {{AdlConfKeys}} which indicates these
are conf keys.
# The properties all have {{_KEY}} suffix to indicate these are conf keys.
# The property values are in the format of {{aa.bb.cc.dd}}, somewhat a hint of
property names.
> Rename ADLS credential properties
> ---------------------------------
>
> Key: HADOOP-14038
> URL: https://issues.apache.org/jira/browse/HADOOP-14038
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/adl
> Affects Versions: 3.0.0-alpha3
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-14038.001.patch, HADOOP-14038.002.patch,
> HADOOP-14038.003.patch, HADOOP-14038.004.patch, HADOOP-14038.005.patch,
> HADOOP-14038.006.patch
>
>
> Add ADLS credential configuration properties to {{core-default.xml}}.
> Set/document the default value for
> {{dfs.adls.oauth2.access.token.provider.type}} to {{ClientCredential}}.
> Fix {{AdlFileSystem#getAccessTokenProvider}} which implies the provider type
> is {{Custom}}.
> Fix several unit tests that set {{dfs.adls.oauth2.access.token.provider}} but
> does not set {{dfs.adls.oauth2.access.token.provider.type}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
