[
https://issues.apache.org/jira/browse/HADOOP-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905028#comment-15905028
]
Vishwajeet Dusane commented on HADOOP-14038:
--------------------------------------------
Thanks [~jzhuge], Quick glance over the patch5
1. {code}
String hostNameProperty = "fs.adl." + hostname + ".hostname";
String mountPointProperty = "fs.adl." + hostname + ".mountpoint";
{code}
Existing client using {{dfs.adls}} for mount point would fail to initialize.
one way to handle would be to add {{deprecatedHostNameProperty}} &&
{{deprecatedMountPointProperty}} constructed as well with {{dfs.adls}} prefix.
2. Also we should add test to ensure backward compatibility and test to ensure
existing keys name and default value is validated.
{{TestValidateConfiguration}} was responsible for that.
> Rename ADLS credential properties
> ---------------------------------
>
> Key: HADOOP-14038
> URL: https://issues.apache.org/jira/browse/HADOOP-14038
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/adl
> Affects Versions: 3.0.0-alpha3
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-14038.001.patch, HADOOP-14038.002.patch,
> HADOOP-14038.003.patch, HADOOP-14038.004.patch, HADOOP-14038.005.patch
>
>
> Add ADLS credential configuration properties to {{core-default.xml}}.
> Set/document the default value for
> {{dfs.adls.oauth2.access.token.provider.type}} to {{ClientCredential}}.
> Fix {{AdlFileSystem#getAccessTokenProvider}} which implies the provider type
> is {{Custom}}.
> Fix several unit tests that set {{dfs.adls.oauth2.access.token.provider}} but
> does not set {{dfs.adls.oauth2.access.token.provider.type}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
