[ 
https://issues.apache.org/jira/browse/HADOOP-14104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883787#comment-15883787
 ] 

Rushabh S Shah commented on HADOOP-14104:
-----------------------------------------

[~andrew.wang]: Thanks for quick review.
bq. Could you update the documentation and core-default.xml about this new 
feature?
Will update in next revision.

bq. Do we actually need the PB boolean? PB can differentiate between not 
specified, empty string, and set
The default value for string format in protobuf  is "" (empty string).
If the client receives an empty string, it either means its talking to an old 
namenode or the namenode has provider path config not set.
Maybe if the namenode doesn't have security path set, then I can return null 
value and on the client side, I have to differentiate between null and empty 
string. But need to test if protobuf convert null string to empty string in 
response or not ?


> Client should always ask namenode for kms provider path.
> --------------------------------------------------------
>
>                 Key: HADOOP-14104
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14104
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HADOOP-14104-trunk.patch
>
>
> According to current implementation of kms provider in client conf, there can 
> only be one kms.
> In multi-cluster environment, if a client is reading encrypted data from 
> multiple clusters it will only get kms token for local cluster.
> Not sure whether the target version is correct or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to