[
https://issues.apache.org/jira/browse/HADOOP-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421885#comment-15421885
]
Arun Suresh commented on HADOOP-13437:
--------------------------------------
So, the original intent was based on the assumption that defaults and
whitelists should not be changed once KMS is started.. I agree it should have
been doc-ed. (On startup, all KeyOpType defaults and whitelists would be
specified.. and no new defaults and whitelists would be added... which is
reason for the {{containsKey}})
The {{kms-acls.xml}} hot reloading was meant to be used in the event keys and
associated users/groups were added/removed, not for modifying the defaults and
whitelists.
I agree hot reloading of these would make things more flexible though. I guess
we should either:
# move defaults and whitelists to {{kms-site.xml}} and thereby ensure these are
unambiguously NOT hot reloadable.
# as per this JIRA remove the restriction and allow everything to be hot
reloadable.
Thoughts?
> KMS should reload whitelist and default key ACLs when hot-reloading
> -------------------------------------------------------------------
>
> Key: HADOOP-13437
> URL: https://issues.apache.org/jira/browse/HADOOP-13437
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms
> Affects Versions: 2.6.0
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-13437.01.patch, HADOOP-13437.02.patch,
> HADOOP-13437.03.patch, HADOOP-13437.04.patch, HADOOP-13437.05.patch
>
>
> When hot-reloading, {{KMSACLs#setKeyACLs}} ignores whitelist and default key
> entries if they're present in memory.
> We should reload them, hot-reload and cold-start should not have any
> difference in behavior.
> Credit to [~dilaver] for finding this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
