[
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364772#comment-15364772
]
Robert Kanter commented on HADOOP-13254:
----------------------------------------
Not just future contributors, but users might make their own disk validator
plugins that they don't contribute back, which can do really anything. While
we don't need to protect against everything (e.g. I think it's reasonable to
assume they shouldn't call {{System.exit()}}), we should expect some sort of
initialization that might be done in the Constructor.
{quote}The cheapest solution I see is to use locks.{quote}
Another option is to add {{init()}} and {{close()}} methods, similar to what we
have in the {{Service}} classes. This way, I think it's okay to assume that
users should do things like starting threads or similar things in the
{{init()}} method, instead of the constructor; and we give them a nice place to
clean things up in the {{close()}} method.
> Create framework for configurable disk checkers
> -----------------------------------------------
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch,
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch,
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
