[
https://issues.apache.org/jira/browse/HADOOP-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289883#comment-15289883
]
Chris Nauroth commented on HADOOP-13130:
----------------------------------------
Thank you for patch 008. This is looking good. I completed a clean parallel
test run in ~26 minutes against S3 buckets in US-west-2.
Thank you for the clarification on {{eventually}} and {{Callable<Void>}}. That
makes sense.
There is one thing left unaddressed from my last comment. There was an EOF
assertion that used a descriptive message, and I was wondering if you wanted to
do the same for other EOF assertions. I'm not sure if this slipped through the
cracks in 008, or if it was a conscious choice not to change it.
To make sure it's clear, here is the descriptive assertion:
{code}
assertEquals("Expected EOF got char " + (char) c, -1, c);
{code}
...and here are the other ones that might benefit from the same message...
{code}
assertEquals(-1, instream.read(buf));
{code}
{code}
assertEquals(-1, instream.read(instream.getPos(), buf, 0, buf.length));
{code}
{code}
assertEquals(-1, instream.read(shortLen + 510, buf, 0, buf.length));
{code}
> s3a failures can surface as RTEs, not IOEs
> ------------------------------------------
>
> Key: HADOOP-13130
> URL: https://issues.apache.org/jira/browse/HADOOP-13130
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13130-001.patch, HADOOP-13130-002.patch,
> HADOOP-13130-002.patch, HADOOP-13130-003.patch, HADOOP-13130-004.patch,
> HADOOP-13130-005.patch, HADOOP-13130-branch-2-006.patch,
> HADOOP-13130-branch-2-007.patch, HADOOP-13130-branch-2-008.patch
>
>
> S3A failures happening in the AWS library surface as
> {{AmazonClientException}} derivatives, rather than IOEs. As the amazon
> exceptions are runtime exceptions, any code which catches IOEs for error
> handling breaks.
> The fix will be to catch and wrap. The hard thing will be to wrap it with
> meaningful exceptions rather than a generic IOE. Furthermore, if anyone has
> been catching AWS exceptions, they are going to be disappointed. That means
> that fixing this situation could be considered "incompatible" —but only for
> code which contains assumptions about the underlying FS and the exceptions
> they raise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
