[
https://issues.apache.org/jira/browse/HADOOP-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289130#comment-15289130
]
Steve Loughran commented on HADOOP-13130:
-----------------------------------------
h3. guarded log debug statements
I'd left them all alone, just trying to keep the diff down, but may as well
cull them altogether.
h3. append() throws UnsupportedOperationException
I went through and had a look, and no, most implementations just throw an IOE
with random messages. I think we could tighten the FS API there. Created
HADOOP-13172 to cover.
h3. {{String header = operation}}
Moved to {{String.format}} for clarity, fixed.
h3. {{this exception is non-null if the service exception is an s3 on}}
s/on/r/one/
h3. {{eventually}}.
{{Callable}} can throw exceptions, {{Runnable can't}}. I also actually thought
of playing template games and extracting the result, but gave up as it was
hard. That could be a future improvement which the current code sets up.
> s3a failures can surface as RTEs, not IOEs
> ------------------------------------------
>
> Key: HADOOP-13130
> URL: https://issues.apache.org/jira/browse/HADOOP-13130
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13130-001.patch, HADOOP-13130-002.patch,
> HADOOP-13130-002.patch, HADOOP-13130-003.patch, HADOOP-13130-004.patch,
> HADOOP-13130-005.patch, HADOOP-13130-branch-2-006.patch
>
>
> S3A failures happening in the AWS library surface as
> {{AmazonClientException}} derivatives, rather than IOEs. As the amazon
> exceptions are runtime exceptions, any code which catches IOEs for error
> handling breaks.
> The fix will be to catch and wrap. The hard thing will be to wrap it with
> meaningful exceptions rather than a generic IOE. Furthermore, if anyone has
> been catching AWS exceptions, they are going to be disappointed. That means
> that fixing this situation could be considered "incompatible" —but only for
> code which contains assumptions about the underlying FS and the exceptions
> they raise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
