[ 
https://issues.apache.org/jira/browse/HADOOP-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083993#comment-15083993
 ] 

Chris Nauroth commented on HADOOP-12634:
----------------------------------------

[~gouravk], OK, let's keep the test you already wrote, with a few changes:
# Please change the name of the test to 
{{testLazyRenamePendingCanOverwriteExistingFile}}.  I think this will help 
clarify that the intent is to test an internal implementation detail.  The 
current name makes it sounds like we expect any {{FileSystem#rename}} operation 
to be able to overwrite the destination, which would not be true.
# Please ensure that any stream returned from a {{FileSystem#create}} call gets 
closed.  try-with-resources or the {{IOUtils#cleanup}} utility method is 
helpful for this.
# The {{LOG}} statements are unnecessary.  Please remove them.

> Change Lazy Rename Pending Operation Completion of WASB to address case of 
> potential data loss due to partial copy
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12634
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12634
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Gaurav Kanade
>            Assignee: Gaurav Kanade
>            Priority: Critical
>         Attachments: HADOOP-12634.01.patch
>
>
> HADOOP-12334 changed mode of Copy Operation of HBase WAL Archiving to bypass 
> Azure Storage Throttling after retries. This was via client side copy. 
> However a process crash when the copy is partially done would result in a 
> scenario where the source and destination blobs will have different contents 
> and lazy rename pending operation will not handle this thus causing data 
> loss. We need to fix the lazy rename pending operation to address this issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to