[
https://issues.apache.org/jira/browse/HADOOP-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082509#comment-15082509
]
Chris Nauroth commented on HADOOP-12634:
----------------------------------------
[~gouravk], this mostly looks good to me. I just have a comment on testing and
a nitpick.
The test added in {{TestNativeAzureFileSystemLive}} does not exercise the code
change. It does not execute against an atomic rename folder. See
{{TestNativeAzureFileSystemContractPageBlobLive}} and
{{TestNativeAzureFSPageBlobLive}} for examples of tests that configure the
folder to enable atomic rename.
Having said that, I'm not sure how much success we'll have writing a test to
cover this. If you can't find a way to write a test, then please describe any
additional manual testing that you did.
{code}
}
else if (!srcExists && dstExists) {
{code}
The project coding standard is to place the braces inline, so please change to
this:
{code}
} else if (!srcExists && dstExists) {
{code}
> Change Lazy Rename Pending Operation Completion of WASB to address case of
> potential data loss due to partial copy
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12634
> URL: https://issues.apache.org/jira/browse/HADOOP-12634
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Gaurav Kanade
> Assignee: Gaurav Kanade
> Priority: Critical
> Attachments: HADOOP-12634.01.patch
>
>
> HADOOP-12334 changed mode of Copy Operation of HBase WAL Archiving to bypass
> Azure Storage Throttling after retries. This was via client side copy.
> However a process crash when the copy is partially done would result in a
> scenario where the source and destination blobs will have different contents
> and lazy rename pending operation will not handle this thus causing data
> loss. We need to fix the lazy rename pending operation to address this issue
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
