[
https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068993#comment-15068993
]
Kai Zheng commented on HADOOP-12662:
------------------------------------
bq. dist is used by anyone using the tar ball install.
To clarify (please correct me if it's bad), the script only runs in tar ball
building phase, while someone runs {{mvn packge}} with {{-Pdist -Dtar}}
options. So the {{bash}} would be good to be required to be there in the
building environment. It's not for end users. Even for hadoop deployment
environment, I checked relevant daemon/client scripts, and they have already
relied on bash.
bq. I think it's reasonable to split this script out into a separate file.
With the script split out, it's a good chance to rewrite it (nice to use bash
if agreed). For example, a function to bundle a native library would be nice to
have, thus when adding a new native library, a simple line would be added to
call it instead of having to duplicate a block of codes.
> The build should fail if a -Dbundle option fails
> ------------------------------------------------
>
> Key: HADOOP-12662
> URL: https://issues.apache.org/jira/browse/HADOOP-12662
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch
>
>
> Per some discussion with [~cmccabe], it would be good to refine and make it
> consistent the behaviors in bundling native libraries when building dist
> package.
> For all native libraries to bundle, if the bundling option like
> {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}}
> will be checked and ensured to be there, but if not, it will then report
> error and fail the building explicitly.
> {{BUILDING.txt}} would also be updated to explicitly state this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
