[
https://issues.apache.org/jira/browse/TAP5-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18047896#comment-18047896
]
Hudson commented on TAP5-2809:
------------------------------
FAILURE: Integrated in Jenkins build Tapestry »
tapestry-javax-java-11-freestyle #89 (See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-javax-java-11-freestyle/89/])
TAP5-2809: Gradle project setup overhaul (benw: rev
a3a4ef92a291c6e1effb371eb874489b8322be4c)
* (delete) tapestry-hibernate-core/src/test/conf/testng.xml
* (edit) tapestry-jpa/src/test/java/org/example/app6/entities/User.java
* (edit) gradlew.bat
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/JavaScriptStackMinimizeDisabler.java
* (add) tapestry-jmx/src/test/resources/testng.xml
* (edit) tapestry-ioc/src/test/groovy/ioc/specs/GeneralIntegrationSpec.groovy
* (edit) tapestry-mongodb/build.gradle
* (add) tapestry-spring/src/test/resources/testng.xml
* (edit) tapestry-test/build.gradle
* (edit) beanmodel/build.gradle
* (add) buildSrc/build.gradle
* (edit) tapestry-ioc-junit/build.gradle
* (edit) tapestry-func/src/test/java/org/apache/tapestry5/func/BaseFuncTest.java
* (edit)
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapper.java
* (add) tapestry-json/src/test/java/org/apache/tapestry5/json/CoercionsTest.java
* (edit) settings.gradle
* (add) tapestry-json/src/test/java/org/apache/tapestry5/json/JSONArrayTest.java
* (delete) tapestry5-annotations/src/test/conf/testng.xml
* (edit)
tapestry-webresources/src/test/java/t5/webresources/services/web/WebResourcesTest.java
* (edit)
tapestry-http/src/main/java/org/apache/tapestry5/http/internal/services/DefaultCorsHandler.java
* (edit) tapestry-ioc/src/test/groovy/ioc/specs/ChainBuilderImplSpec.groovy
* (edit)
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/integration/app5/DummyEntityManager.java
* (delete) tapestry-kaptcha/src/test/conf/testng.xml
* (edit) tapestry-runner/build.gradle
* (edit)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/ModuleDef.java
* (add) buildSrc/src/main/groovy/t5build/Scp.groovy
* (edit) gradlew
* (edit) genericsresolver-guava/build.gradle
* (delete) tapestry-json/src/test/groovy/json/specs/JSONCollectorsSpec.groovy
* (delete) tapestry-mongodb/src/test/conf/testng.xml
* (edit)
tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java
* (edit) quickstart/src/main/resources-filtered/archetype-resources/pom.xml
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java
* (edit) tapestry-core/build.gradle
* (add) tapestry-hibernate/src/test/resources/testng.xml
* (delete) tapestry-beanvalidator/src/test/conf/testng.xml
* (edit)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/TestRegistryManager.java
* (edit)
plastic/src/test/groovy/org/apache/tapestry5/plastic/FieldPropertyMethodCreation.groovy
* (delete) tapestry-core/src/test/conf/testng-limited.xml
* (edit) tapestry5-annotations/build.gradle
* (add) tapestry-json/src/test/java/org/apache/tapestry5/json/JSONTest.java
* (edit)
tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java
* (add)
tapestry-json/src/test/java/org/apache/tapestry5/json/JSONCollectorsTest.java
* (add) tapestry-mongodb/src/test/resources/testng.xml
* (add) tapestry-jpa/src/test/resources/testng.xml
* (edit) tapestry-kaptcha/build.gradle
* (edit) tapestry-rest-jackson/build.gradle
* (add) tapestry-kaptcha/src/test/resources/testng.xml
* (edit) tapestry-jpa/build.gradle
* (edit)
tapestry-http/src/test/java/org/apache/tapestry5/http/test/services/AppModule.java
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
* (delete) tapestry-json/src/test/groovy/json/specs/JSONSpec.groovy
* (edit) tapestry-json/build.gradle
* (add) buildSrc/src/main/groovy/t5build/SshTask.groovy
* (edit)
quickstart/src/main/resources-filtered/archetype-resources/pom-spring-boot.xml
* (edit)
tapestry-clojure/src/test/java/org/apache/tapestry5/clojure/tests/TestModule.java
* (add) tapestry-hibernate-core/src/test/resources/testng.xml
* (edit)
tapestry-http/src/test/java/org/apache/tapestry5/http/internal/services/CorsHandlerHelperImplTest.java
* (edit) tapestry-cdi/build.gradle
* (add) tapestry-core/src/test/resources/testng.xml
* (edit)
tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/PartialTemplateRendererTests.groovy
* (edit) tapestry-test-data/build.gradle
* (edit) tapestry-webresources/src/test/resources/META-INF/modules/index.coffee
* (edit) tapestry-hibernate/build.gradle
* (add) tapestry-test/src/test/resources/testng.xml
* (add) buildSrc/src/main/groovy/tapestry.testing-base-convention.gradle
* (edit)
tapestry-func/src/test/java/org/apache/tapestry5/func/FlowToSetTests.java
* (add)
tapestry-json/src/test/java/org/apache/tapestry5/json/JSONObjectTest.java
* (edit) tapestry-ioc/build.gradle
* (add) buildSrc/src/main/groovy/tapestry.junit5-spock-convention.gradle
* (edit)
tapestry-func/src/test/java/org/apache/tapestry5/func/ZippedFlowTests.java
* (edit) quickstart/build.gradle
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxFormUpdateController.java
* (add)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnitExtension.java
* (add) buildSrc/src/main/groovy/t5build/SSshExec.groovy
* (edit) tapestry-hibernate-core/build.gradle
* (delete) tapestry-jpa/src/test/conf/testng.xml
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DocumentLinker.java
* (edit)
tapestry-http/src/test/java/org/apache/tapestry5/http/internal/services/CorsHttpServletRequestFilterTest.java
* (edit) tapestry-webresources/build.gradle
* (edit) tapestry-beanvalidator/build.gradle
* (edit)
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/integration/app5/DummyEntityManagerFactory.java
* (delete)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit4ClassRunnerAfterClassTest.java
* (edit) tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java
* (delete) tapestry-core/src/test/conf/testng.xml
* (edit) tapestry-mongodb/src/test/groovy/MongoDBSpec.groovy
* (edit) gradle/wrapper/gradle-wrapper.properties
* (delete) tapestry-json/src/test/conf/testng.xml
* (add) buildSrc/src/main/groovy/t5build/GenerateChecksums.groovy
* (delete) tapestry-json/src/test/groovy/json/specs/JSONObjectSpec.groovy
* (edit) tapestry-jpa/src/test/java/org/example/app1/entities/User.java
* (add)
tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/ResourceMinimizationException.java
* (add) buildSrc/src/main/groovy/t5build/TapestryBuildLogic.groovy
* (delete)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit4ClassRunner.java
* (add) buildSrc/src/main/groovy/tapestry.junit4-legacy-convention.gradle
* (edit) tapestry-func/src/test/java/org/apache/tapestry5/func/TupleTests.java
* (add) buildSrc/src/main/groovy/tapestry.junit5-convention.gradle
* (add) buildSrc/src/main/groovy/tapestry.ssh-convention.gradle
* (add) tapestry-core/src/test/resources/testng-limited.xml
* (edit)
plastic/src/test/groovy/org/apache/tapestry5/plastic/MethodAnnotationAccess.groovy
* (edit) tapestry-latest-java-tests/build.gradle
* (edit)
tapestry-rest-jackson/src/main/java/org/apache/tapestry5/jacksondatabind/services/ObjectMapperSource.java
* (edit) tapestry-openapi-viewer/build.gradle
* (edit)
plastic/src/test/groovy/org/apache/tapestry5/plastic/MethodProxying.groovy
* (edit) tapestry-spock/build.gradle
* (edit)
tapestry-func/src/test/java/org/apache/tapestry5/func/TakeDropTests.java
* (delete) plastic/src/test/conf/testng.xml
* (edit) tapestry-spring/build.gradle
* (add) tapestry-upload/src/test/resources/testng.xml
* (edit) tapestry-jmx/build.gradle
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
* (edit) commons/build.gradle
* (edit)
tapestry-func/src/test/java/org/apache/tapestry5/func/StringPredicateTests.java
* (edit) tapestry-javadoc/build.gradle
* (edit)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/RegistryShutdownType.java
* (edit) tapestry-ioc-jcache/build.gradle
* (add) buildSrc/src/main/groovy/tapestry.java-convention.gradle
* (delete) tapestry-json/src/test/groovy/json/specs/JSONArraySpec.groovy
* (add) tapestry-beanvalidator/src/test/resources/testng.xml
* (edit) build.gradle
* (delete) tapestry-spring/src/test/conf/testng.xml
* (delete) tapestry-test/src/test/conf/testng.xml
* (delete) tapestry-jmx/src/test/conf/testng.xml
* (edit) tapestry-version-migrator/build.gradle
* (delete) sha256.gradle
* (edit) tapestry-func/src/test/java/org/apache/tapestry5/func/RangeTests.java
* (add)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit5ModuleDefTest.java
* (add) gradle/libs.versions.toml
* (edit) tapestry-clojure/build.gradle
* (edit) gradle/wrapper/gradle-wrapper.jar
* (edit) tapestry-http/build.gradle
* (delete)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit4ClassRunnerAfterMethodTest.java
* (edit)
tapestry-func/src/test/java/org/apache/tapestry5/func/InterleaveTests.java
* (edit) plastic/build.gradle
* (delete) tapestry-json/src/test/groovy/json/specs/CoercionsSpec.groovy
* (edit)
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/integration/app5/DummyPersistenceProvider.java
* (edit)
tapestry-ioc-junit/src/main/java/org/apache/tapestry5/ioc/junit/Registry.java
* (delete) tapestry-hibernate/src/test/conf/testng.xml
* (edit)
tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentDependencyRegistryImplTest.java
* (add)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit5AfterClassTest.java
* (edit) tapestry-upload/build.gradle
* (delete) tapestry-func/src/test/conf/testng.xml
* (add) buildSrc/src/main/groovy/tapestry.testng-convention.gradle
* (delete) ssh.gradle
* (edit) tapestry-func/build.gradle
* (edit) tapestry-internal-test/build.gradle
* (add)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit5AfterMethodTest.java
* (edit) tapestry-func/src/test/java/org/apache/tapestry5/func/MapperTest.java
* (delete)
tapestry-ioc-junit/src/test/java/org/apache/tapestry5/ioc/junit/TapestryIOCJUnit4ClassRunnerModuleDefTest.java
* (delete) tapestry-upload/src/test/conf/testng.xml
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentEventRequestFilter.java
> Improve/Fix Gradle Setup
> ------------------------
>
> Key: TAP5-2809
> URL: https://issues.apache.org/jira/browse/TAP5-2809
> Project: Tapestry 5
> Issue Type: Task
> Affects Versions: 5.9.1
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Major
>
> The current Gradle setup has multiple issues:
> * Pre-Java 8 remnants
> * Incomplete upgrade to JUnit 5
> * Incorrect testng.xml
> * Misaligned dependency version between projects
>
> To improve the situation, I suggest:
> * Remove all pre-Java 8 options
> * Create Gradle conventions for
> ** Subproject setup
> ** JUnit 5 (+Spock)
> ** TestNG (and move testng.xml to default locations)
> ** JUnit 4 for legacy reasons
> * Introducing version catalogs for shared dependencies and a consistent
> declaration of module-specific dependencies.
>
> In a second step, more tasks, like Javadoc-related tasks or publishing, could
> be done with conventions or build plugins, to make them easier to use and
> maintain.
> The overall risk is breaking the build and breaking changes for Tapestry
> users if a dependency is no longer exposed.
> However, choosing the right configuration so as not to accidentally export
> dependencies is more critical, and the error messages should clearly state
> why a build is no longer working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
