[ 
https://issues.apache.org/jira/browse/TAP5-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898603#comment-17898603
 ] 

Ben Weidig commented on TAP5-2790:
----------------------------------

Are you sure about "optgoup" coming from Tapestry?
The String doesn't exist in the code base and the SelectModelRenderer didn't 
write anything optgroup-related to the option tag before tag.

Here's the expected grouped-option output used for a unit test before my 
changes:
https://github.com/apache/tapestry-5/blob/a02db6c6310b50a6498c5a22c3d212b62e5324bf/tapestry-core/src/test/resources/org/apache/tapestry5/corelib/components/option_group_attributes.txt

Nevertheless, I've added the optgroup-idx to the option, so it's easier to add 
it back.

> Palette with option groups within the SelectModel does not work properly.
> -------------------------------------------------------------------------
>
>                 Key: TAP5-2790
>                 URL: https://issues.apache.org/jira/browse/TAP5-2790
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.9.0, 5.8.7
>            Reporter: LRein
>            Assignee: Ben Weidig
>            Priority: Trivial
>              Labels: easyfix
>         Attachments: palette.js
>
>
> Option Groups are displayed correctly in the Palette. If you select options 
> and then deselect them again, they are not placed in the correct option group.
> I am currently correcting the behavior of the Palette when overwriting the 
> palette.js. But it would be much better if you could adopt the corrected 
> behavior.
> {code:java}
> @Contribute(ModuleManager.class)
> public static void overrideTapestryCoreModules(
>        MappedConfiguration<String, Object> configuration,
>        @Path("META-INF/assets/js/override/palette.js") Resource palette)
> {
>     configuration.add("t5/core/palette", new 
> JavaScriptModuleConfiguration(palette));
> } {code}
>  
> In Attachments is the change that corrects the behavior of the palette.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to