[
https://issues.apache.org/jira/browse/TAP5-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761473#comment-17761473
]
Hudson commented on TAP5-2761:
------------------------------
SUCCESS: Integrated in Jenkins build Tapestry ยป tapestry-java-17-freestyle #67
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-17-freestyle/67/])
TAP5-2761: ResourceStreamer#streamResource documentation clarified and NPE
fixed (ben: rev ca1c40375658a4da36a7792ae5c6778f6d275e12)
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamer.java
> ResourceStreamer#streamResource(Resource, String, Set) throws NPE if
> providedChecksum is null
> ---------------------------------------------------------------------------------------------
>
> Key: TAP5-2761
> URL: https://issues.apache.org/jira/browse/TAP5-2761
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.8.3
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Minor
>
> The documentation of
> {{org.apache.tapestry5.internal.services.ResourceStreamer.streamResource(Resource,
> String, Set<Options>)}} states it accepts {{null}} for its second argument
> ({{providedChecksum}}, but it doesn't.
> The
> {{org.apache.tapestry5.internal.services.ResourceStreamerImpl.streamResource(StreamableResource,
> String, Set<Options>)}}, however, states that {{providedChecksum}} is
> allowed to be blank.
> The term "blank" can be understood in different ways:
> * Tools like Apache StringUtils interpret blank as "null or whitespace only"
> * Java's {{String}} class has a {{isBlank()}}, which obviously requires the
> instance to exist
> To make the behavior more obvious, the documentation should state "null or
> blank", and the underlying code should handle it accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
