[
https://issues.apache.org/jira/browse/TAP5-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740909#comment-17740909
]
ASF subversion and git services commented on TAP5-2708:
-------------------------------------------------------
Commit 4ffc309fc6c0b7f5c16235b2aa5a8aa1aeaada93 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4ffc309fc ]
TAP5-2708/2753: CssCompressor updates and CSS variable fixes (#40)
The CssCompressor in tapestry-webresources is now based on the latest YUI
commit cf0497e.
To make the original code work it needed some error fixing:
- Duplicate variable declaration of "oldCss"
- Faulty non-escaped regex
- zeros.css test failed
I'm not 100% sure the CssCompressor behaves 100% as before, but it's a
necessary trade-off so it can be improved further, as the original YUI project
is dead.
All the pre-existing tests from YUI are now run directly in Tapestry, and we
can add our own tests easily.
Furthermore, the code was cleaned up with pre-compiled Patterns, and no longer
converting between Strings/Readers/Writers.
Co-authored-by: Volker Lamp <vl...@apache.org>
> CssCompressor update/optimizations
> ----------------------------------
>
> Key: TAP5-2708
> URL: https://issues.apache.org/jira/browse/TAP5-2708
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-webresources
> Affects Versions: 5.8.0
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Minor
> Fix For: 5.8.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CssCompressor used by Tapestry is a copy of the YUI Compresser for CSS.
> Minification breaks/outputs wrong content for some edge cases, and the code
> in general code be optimized, like pre-compiled Patterns.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
