[
https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740916#comment-17740916
]
ASF subversion and git services commented on TAP5-2739:
-------------------------------------------------------
Commit 14864a28b20542e2b57d74e226919a0f66ed3092 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14864a28b ]
TAP5-2739: tapestry-ioc JDKUtils and DummyLock removed
Both classes are special considerations for Java 1.5 which isn't supported
since Tapestry 5.3+.
Even if someone still uses the internal JDKUtils to create a lock for
ThreadLocal creation, it makes sense to remove it as the DummyLock does
actually nothing.
> Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and
> org.apache.tapestry5.ioc.internal.util.DummyLock
> -----------------------------------------------------------------------------------------------------------
>
> Key: TAP5-2739
> URL: https://issues.apache.org/jira/browse/TAP5-2739
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-ioc
> Affects Versions: 5.8.2
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Minor
>
> The class is a remnant from 5.3->5.4 / Java 5->6 transition.
> Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is
> outdated und Java 1.6 is required for Tapestry 5.4+.
> In relatity, Java 8 is needed, so it makes no longer sense to have the check.
>
> The other method of the class,
> createLockForThreadLocalCreation()), isnt used at all in Tapestry itself.
> The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is
> deprecated since 5.4
>
> Both classes should be removed, because they don't serve any purpose.
> Being in an internal package should make the removal not an issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
