[
https://issues.apache.org/jira/browse/TAP5-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717971#comment-14717971
]
Kalle Korhonen commented on TAP5-2482:
--------------------------------------
Unless Howard provides more reasoning as to why this change is needed, I'd vote
for rolling it back. Howard had added the following comments in the release
notes as part of the issue:
"As before, the id is made unique with an optional numeric suffix; however with
this change it is possible, in some complex Ajax-related cases (involving
FormFragment or FormInjector components) for there to be name collisions that
were not possible before."
Implying this change may cause issues later on.
> BeanEditForm field name regression introduced with 5.4-beta-31
> --------------------------------------------------------------
>
> Key: TAP5-2482
> URL: https://issues.apache.org/jira/browse/TAP5-2482
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.4
> Reporter: Balázs Palcsó
> Labels: 54_release_prerequisite
>
> Issue started with: 5.4-beta-31
> Last working release: 5.4-beta-30
> I have the below BeanEditForm
> {code}
> <t:beaneditor t:object="user"
>
> include="username,lastName,firstName,email,phone,password,confirmPassword">
> <p:username>
> <div class="form-group">
> <t:label for="username" />
> <t:textfield t:id="username" value="user.username"
> t:mixins="OverrideFieldFocus" />
> </div>
> </p:username>
> <p:password>
> <div class="form-group">
> <t:label for="password" />
> <t:passwordfield t:id="password" value="user.password"
> />
> </div>
> </p:password>
> <p:confirmPassword>
> <div class="form-group">
> <t:label for="confirmPassword" />
> <t:passwordfield t:id="confirmPassword"
> value="user.confirmPassword" />
> </div>
> </p:confirmPassword>
> </t:beaneditor>
> {code}
> The {{name}} attribute of the input generated for each included fields were
> matching the field name until 5.4-beta-31.
> With 5.4-beta-31 the above form generates the following name attribute for
> {{<input />}} for
> {{name="textField"}} instead of {{name="lastName"}}
> {{name="textField_0"}} instead of {{name="firstName"}}
> {{name="textField_1"}} instead of {{name="phone"}}
> For username, email, password, confirmPassword correct name attributes are
> generated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
