Radiancebobo commented on code in PR #25939:
URL: https://github.com/apache/pulsar/pull/25939#discussion_r3361925786
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##########
@@ -238,11 +251,13 @@ public synchronized CompletableFuture<T>
sequential(Supplier<CompletableFuture<T
if (sequencerFuture.isCompletedExceptionally() &&
allowExceptionBreakChain) {
return sequencerFuture;
}
- return sequencerFuture = newTask.get();
+ return sequencerFuture = getFutureSafely(newTask, "Expected
Supplier should not return null");
Review Comment:
> fix the compilation issues after the renaming
Sorry about that! I applied the changes directly on GitHub and missed the
other parts that needed to be updated in sync. My local environment isn't
updated yet, but I'll get on it and fix everything later today. I'll be more
careful next time. Thanks for your patience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
