lhotari commented on code in PR #25939:
URL: https://github.com/apache/pulsar/pull/25939#discussion_r3361724105
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java:
##########
@@ -238,11 +251,13 @@ public synchronized CompletableFuture<T>
sequential(Supplier<CompletableFuture<T
if (sequencerFuture.isCompletedExceptionally() &&
allowExceptionBreakChain) {
return sequencerFuture;
}
- return sequencerFuture = newTask.get();
+ return sequencerFuture = getFutureSafely(newTask, "Expected
Supplier should not return null");
Review Comment:
We'd need to update the AGENTS.md/CONTRIBUTING.md to make it more explicit
that this step is necessary before more changes are pushed to a PR:
```
# Lint / verify (license headers, formatting, checkstyle) — run before
pushing
./gradlew rat spotlessCheck checkstyleMain checkstyleTest
```
https://github.com/apache/pulsar/blob/master/CONTRIBUTING.md#building
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
