lhotari commented on code in PR #25883:
URL: https://github.com/apache/pulsar/pull/25883#discussion_r3361430938
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -533,6 +539,16 @@ jobs:
${{ matrix.runtime_jdk != env.CI_JDK_MAJOR_VERSION &&
matrix.runtime_jdk || '' }}
${{ env.CI_JDK_MAJOR_VERSION }}
+ # The NATIVE_IMAGE group compiles a native binary with GraalVM
native-build-tools,
+ # which requires a GraalVM JDK. This overrides JAVA_HOME for that matrix
entry only.
+ - name: Set up GraalVM
+ if: ${{ matrix.group == 'NATIVE_IMAGE' }}
+ uses: graalvm/setup-graalvm@v1
Review Comment:
For ASF projects, GitHub Actions must use a fixed hash. The approved hashes
are available in
https://github.com/apache/infrastructure-actions/blob/main/actions.yml#L491
```suggestion
uses: graalvm/setup-graalvm@329c42c5f4c343bceb505f0b28cc8499bc2bf174
# v1.5.4
```
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -533,6 +539,16 @@ jobs:
${{ matrix.runtime_jdk != env.CI_JDK_MAJOR_VERSION &&
matrix.runtime_jdk || '' }}
${{ env.CI_JDK_MAJOR_VERSION }}
+ # The NATIVE_IMAGE group compiles a native binary with GraalVM
native-build-tools,
+ # which requires a GraalVM JDK. This overrides JAVA_HOME for that matrix
entry only.
+ - name: Set up GraalVM
+ if: ${{ matrix.group == 'NATIVE_IMAGE' }}
+ uses: graalvm/setup-graalvm@v1
+ with:
+ distribution: 'graalvm-community'
+ java-version: ${{ env.CI_JDK_MAJOR_VERSION }}
+ github-token: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
There shouldn't be a need to pass the github-token although graalvm's
documentation claims that it should be done. The default value is `${{
github.token }}` which is the same as `${{ secrets.GITHUB_TOKEN }}` unless
`GITHUB_TOKEN` secret is explicitly provided. Let's remove this.
```suggestion
```
##########
gradle/libs.versions.toml:
##########
@@ -145,6 +145,7 @@ jakarta-servlet = "6.0.0"
oxia = "0.7.4"
# Build plugins
lightproto = "0.7.3"
+graalvm-buildtools = "0.10.6"
Review Comment:
Latest version is `1.1.1`
```suggestion
graalvm-buildtools = "1.1.1"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
