lhotari commented on code in PR #25883: URL: https://github.com/apache/pulsar/pull/25883#discussion_r3350351776
########## tests/pulsar-client-native-image/pom.xml: ########## Review Comment: master branch contains a gradle build. Please see `tests/pulsar-client-all-shade-test/build.gradle.kts` as a reference. In Gradle, you should use GraalVM's Gradle plugin, https://graalvm.github.io/native-build-tools/latest/gradle-plugin.html ########## tests/pom.xml: ########## Review Comment: The master branch no longer uses maven, so this is obsolete. The new project should be added to top level `settings.gradle.kts`. ########## .github/workflows/ci-pulsar-native-image.yaml: ########## @@ -0,0 +1,78 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: CI - Native Image +on: + # Native-image builds are slow, so this does not run on every PR. It runs nightly, + # can be triggered manually, and on PRs that touch the native-image metadata or its test. + schedule: + - cron: '30 1 * * *' + workflow_dispatch: + pull_request: + branches: + - master + paths: + - '.github/workflows/ci-pulsar-native-image.yaml' + - '**/META-INF/native-image/**' + - 'tests/pulsar-client-native-image/**' + +env: + MAVEN_OPTS: -Xss1500k -Xmx1500m -Daether.connector.http.reuseConnections=false -Daether.connector.requestTimeout=60000 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dmaven.wagon.http.serviceUnavailableRetryStrategy.class=standard -Dmaven.wagon.rto=60000 + +jobs: + native-image-smoke-test: Review Comment: How slow are native image builds? Since Pulsar CI's integration tests run in parallel, it shouldn't be a problem if it's relatively slow. If it takes more than 20 minutes, that's when it starts becoming a problem. It would be preferred to add a new entry to Pulsar CI's integration test matrix instead of adding a new GitHub Actions workflow: https://github.com/apache/pulsar/blob/a1b0a4fa15fc6620dabfbc8c83664556f8debd65/.github/workflows/pulsar-ci.yaml#L458-L512 When using the integration test matrix solution, actual commands to run the test group are added to the `pulsar-build/run_integration_group_gradle.sh` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
