lhotari commented on code in PR #25921:
URL: https://github.com/apache/pulsar/pull/25921#discussion_r3349023587
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java:
##########
@@ -304,4 +306,12 @@ private void stop() {
public void close() {
stop();
}
+
+ protected static boolean messageBelongsToTopic(MessageId messageId, String
topicName) {
Review Comment:
the name of this method is vague. It would be useful to add a javadoc to
explain the contract.
Perhaps moving the method as an instance method of `TopicMessageId` would
make more sense.
Naming the method continues to be a challenge also in that case, but it
could make it slightly easier since there's proper context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
