Dream95 opened a new pull request, #25921:
URL: https://github.com/apache/pulsar/pull/25921
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. The valid
`[type]` and `[component]`/scope
prefixes are enforced by CI (see
`.github/workflows/ci-semantic-pull-request.yml`); for details,
see *[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- The **Motivation** and **Modifications** sections are required: explain
*why* (the problem/context)
and *what/how* (the change). A title alone, or a description that only
restates the title, is not enough.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- For the local build/test/PR workflow see `CONTRIBUTING.md`, and for
coding conventions see
`CODING.md`. If you use an AI coding assistant, see `AGENTS.md`.
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Details of when a PIP is required and how the PIP process work, please
see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
When a multi-topic consumer unsubscribes from a topic, it removes unacked
messages that belong to the unsubscribed topic.
The previous matching logic used substring matching on
`TopicMessageId#getOwnerTopic()`. This could incorrectly remove messages from
topics with similar prefixes, such as matching `my-topic-v2` when unsubscribing
`my-topic`.
### Modifications
- Normalize both the message owner topic and the target topic to their
partitioned topic name before comparing them.
- Remove unacked messages for all partitions of the unsubscribed logical
topic.
- Add test coverage to verify that similarly prefixed topics are not removed
by mistake.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
`./gradlew :pulsar-client-original:test --tests
org.apache.pulsar.client.impl.UnAckedTopicMessageRedeliveryTrackerTest`
### Verifying this change
- [x] Added unit tests for unacked topic message cleanup.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
