void-ptr974 commented on PR #25915: URL: https://github.com/apache/pulsar/pull/25915#issuecomment-4597972779
> @poorbarcode I'm thinking another solution > > 1. Close the replicator producer if the producer is idle for a while (e.g. 10 mins) > 2. Check all the producers for detecting the inactive topic (now it's more complicated to skip the replicator producer) > 3. Only delete the inactive topic if there is no producers (including the replicator producer) > > Now, your solution added 7 days delay for inactive topic deletion if geo-replication enable. But if there is no messages from last 7 days, the issue can still happen, right? I agree with this concern. A replicated topic can be quiet for longer than the threshold while the replication relationship is still valid. Using `latestPublishTime` here makes topic deletion depend on the traffic pattern instead of the producer lifecycle. It seems cleaner to let the replicator close its producer explicitly when it is really idle, and let topic GC only check whether producers still exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
