lhotari commented on code in PR #25915:
URL: https://github.com/apache/pulsar/pull/25915#discussion_r3337060132
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -812,6 +812,14 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
)
private Integer brokerDeleteInactiveTopicsMaxInactiveDurationSeconds =
null;
+ @FieldContext(
+ category = CATEGORY_POLICIES,
+ dynamic = true,
+ doc = "Time in seconds after which a replicator is considered inactive
when no replication activity is"
+ + " observed."
Review Comment:
Please improve the documentation of this configuration setting. Make it
explicit that `brokerReplicationInactiveThresholdSeconds` is related to
`brokerDeleteInactiveTopicsEnabled`.
For example:
```java
doc = "Time in seconds since a replicator's producer last sent a
message, after which the replicator"
+ " is considered inactive. When inactive-topic deletion is
enabled (via"
+ " brokerDeleteInactiveTopicsEnabled, or enabled by
namespace/topic policy), a replicated"
+ " topic is eligible for deletion only once all its
replicators have been inactive for this"
+ " duration."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
