nodece commented on code in PR #25592:
URL: https://github.com/apache/pulsar/pull/25592#discussion_r3158267139
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -362,17 +361,6 @@ public synchronized void readMoreEntries() {
// increment the counter for readMoreEntries calls, to track the
number of times readMoreEntries is called
readMoreEntriesCallCount++;
- // remove possible expired messages from redelivery tracker and
pending acks
- Position markDeletePosition = cursor.getMarkDeletedPosition();
- if (lastMarkDeletePositionBeforeReadMoreEntries != markDeletePosition)
{
Review Comment:
I think retention trimming is unrelated here.
Messages only become eligible for retention trimming after they have already
been removed by ack, expiry, skip, or clear-backlog operations. Those are
already the paths where pending-acks cleanup happens now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
